Merge pull request #388 from pehala/remove_skip_cleanup

Remove skip_cleanup as it was never fully working

config/settings.local.yaml.tpl

@@ -1,5 +1,4 @@
 #default:
-#  skip_cleanup: false
 #  tester: "someuser"                          # Optional: name of the user, who is running the tests, defaults to whoami/uid
 #  cluster:                                    # Workload cluster where tests should run, will get overriden if run on Multicluster
 #    project: "kuadrant"                       # Optional: Default namespace for this cluster

config/settings.yaml

@@ -1,5 +1,4 @@
 default:
-  skip_cleanup: false
   dynaconf_merge: true
   cluster: {}
   tools:

testsuite/tests/conftest.py

@@ -163,9 +163,6 @@ def rhsso(request, testconfig, blame, skip_or_fail):
             cnf["test_user"]["password"],
         )
 
-        if not testconfig["skip_cleanup"]:
-            request.addfinalizer(info.delete)
-
         info.commit()
         return info
     except KeycloakAuthenticationError:

testsuite/tests/kuadrant/authorino/dinosaur/conftest.py

@@ -11,7 +11,7 @@
 
 
 @pytest.fixture(scope="session")
-def admin_rhsso(request, testconfig, blame, rhsso):
+def admin_rhsso(blame, rhsso):
     """RHSSO OIDC Provider fixture"""
 
     info = RHSSO(
@@ -24,8 +24,6 @@ def admin_rhsso(request, testconfig, blame, rhsso):
         rhsso.test_password,
     )
 
-    if not testconfig["skip_cleanup"]:
-        request.addfinalizer(info.delete)
     info.commit()
     return info