Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RLP tests with authz #209

Merged
merged 1 commit into from
Nov 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions testsuite/openshift/objects/rate_limit.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,15 @@ def create_instance(cls, openshift: OpenShiftClient, name, route: Referencable,
return cls(model, context=openshift.context)

@modify
def add_limit(self, name, limits: Iterable[Limit], when: Iterable[Rule] = None):
def add_limit(self, name, limits: Iterable[Limit], when: Iterable[Rule] = None, counters: list[str] = None):
"""Add another limit"""
limit = {
limit: dict = {
"rates": [asdict(limit) for limit in limits],
}
if when:
limit["when"] = [asdict(rule) for rule in when]
if counters:
limit["counters"] = counters
self.model.spec.limits[name] = limit

def commit(self):
Expand Down
49 changes: 49 additions & 0 deletions testsuite/tests/kuadrant/test_rate_limit_authz.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
"""Tests for basic authenticated rate limiting"""

import pytest

from testsuite.httpx.auth import HttpxOidcClientAuth
from testsuite.objects import ValueFrom
from testsuite.openshift.objects.rate_limit import Limit


@pytest.fixture(scope="module")
def rate_limit(rate_limit):
"""Add limit to the policy"""
rate_limit.add_limit(
"basic", [Limit(5, 60)], counters=[r"metadata.filter_metadata.envoy\.filters\.http\.ext_authz.identity.user"]
)
return rate_limit


@pytest.fixture(scope="module")
def authorization(authorization):
"""Adds JSON injection, that wraps the response as Envoy Dynamic Metadata for rate limit"""
authorization.responses.add_json(
"identity", {"user": ValueFrom("auth.identity.preferred_username")}, wrapper="dynamicMetadata"
)
return authorization


@pytest.fixture(scope="module")
def auth(oidc_provider):
"""Returns RHSSO authentication object for HTTPX"""
return HttpxOidcClientAuth(oidc_provider.get_token, "authorization")


@pytest.fixture(scope="module")
def auth2(rhsso):
"""Creates new RHSSO user and returns its authentication object for HTTPX"""
name = rhsso.user.username + "-test2"
user = rhsso.realm.create_user(name, "password", email="[email protected]")
return HttpxOidcClientAuth.from_user(rhsso.get_token, user=user)


def test_authz_limit(client, auth, auth2):
"""Tests that rate limit is applied for two users independently"""
responses = client.get_many("/get", 5, auth=auth)
assert all(
r.status_code == 200 for r in responses
), f"Rate Limited resource unexpectedly rejected requests {responses}"
assert client.get("/get", auth=auth).status_code == 429
assert client.get("/get", auth=auth2).status_code == 200