Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor testsuite to be more aligned with Gateway API #257

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Nov 1, 2023

  • New structure contains these fixture/parts
    • backend() + Httpbin class - Backend to which the requests should get routed
    • gateway() fixture + Gateway class - Equivalent of Gateway object in Gateway API
    • route() fixture + GatewayRoute class - Equivalent of HTTPRoute object in Gateway API
    • exposer() fixture + Exposer class - Responsible for exposing hostname to be accessible outside of a cluster
      • For Service Protection only, it is be OpenShiftExposer, which uses OpenShift routes
      • For MGC it is DNSPolicyExposer, which relies on DNSPolicy to do the heavy lifting and expose the actual hostname
    • hostname() fixture and Hostname class - Exposed Hostname, for which we can create HTTP client to send requests
  • Redone pure Envoy deployment
    • Make to emulate how Gateway API works - it is now slower due to a few rollouts needed
    • Update config instead of having to create new template file for each configuration (e.g. Wristband and TLS)
  • Simplified some tests due to the new structure

@pehala pehala marked this pull request as draft November 1, 2023 13:04
@averevki averevki self-requested a review November 2, 2023 14:16
@pehala pehala marked this pull request as ready for review November 6, 2023 08:51
testsuite/objects/gateway.py Show resolved Hide resolved
testsuite/objects/hostname.py Outdated Show resolved Hide resolved
testsuite/objects/hostname.py Outdated Show resolved Hide resolved
testsuite/objects/hostname.py Outdated Show resolved Hide resolved
testsuite/objects/gateway.py Show resolved Hide resolved
testsuite/openshift/objects/gateway_api/route.py Outdated Show resolved Hide resolved
testsuite/tests/conftest.py Outdated Show resolved Hide resolved
testsuite/tests/mgc/conftest.py Outdated Show resolved Hide resolved
@jsmolar
Copy link
Contributor

jsmolar commented Nov 9, 2023

move objects.__init__ to openshift.

@pehala pehala force-pushed the rewrite_gw branch 2 times, most recently from 31bf981 to 3b232bf Compare November 13, 2023 13:21
averevki
averevki previously approved these changes Nov 14, 2023
Copy link
Contributor

@averevki averevki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsmolar
jsmolar previously approved these changes Nov 15, 2023
@pehala pehala dismissed stale reviews from jsmolar and averevki via 60b4d7f November 16, 2023 13:05
@pehala pehala merged commit 15611dd into Kuadrant:main Nov 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants