-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor testsuite to be more aligned with Gateway API #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averevki
reviewed
Nov 8, 2023
jsmolar
reviewed
Nov 9, 2023
move |
jsmolar
reviewed
Nov 13, 2023
pehala
force-pushed
the
rewrite_gw
branch
2 times, most recently
from
November 13, 2023 13:21
31bf981
to
3b232bf
Compare
averevki
previously approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jsmolar
previously approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backend()
+Httpbin
class - Backend to which the requests should get routedgateway()
fixture +Gateway
class - Equivalent of Gateway object in Gateway APIroute()
fixture +GatewayRoute
class - Equivalent of HTTPRoute object in Gateway APIexposer()
fixture +Exposer
class - Responsible for exposing hostname to be accessible outside of a clusterOpenShiftExposer
, which uses OpenShift routesDNSPolicyExposer
, which relies on DNSPolicy to do the heavy lifting and expose the actual hostnamehostname()
fixture andHostname
class - Exposed Hostname, for which we can create HTTP client to send requests