Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor settings structure #267

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Nov 6, 2023

  • Rename kuadrant to service_protection
    • Move authorino and envoy under service_protection
  • Rename mgc to control_plane
  • Move kuadrant.enable to gateway_api
  • Change how OpenShift are configured:
    • Introduce cluster configuration, which represent the cluster info where everything should run
      • By default is completely empty, which means that whatever server user is logged in will be used
      • This would be overridden if ran with MGC as the workload will be automatically moved to a spoke
    • All settings in service_protection section are only a projects on the cluster, no other configuration is allowed
    • control_plane.spokes and control_plane.hub (new settings) require a full cluster configuration, same as cluster
  • Change openshift() and openshift2() fixtures to a module scope
    • When running future tests with MGC, the actual client is dependant on the hub gateway and spoke
    • This change means that backend is now also module scope, meaning slower tests

Current minimal configuration:

default:
  skip_cleanup: false
  dynaconf_merge: true
  gateway_api: true
  control_plane:
    hub:
      project: "multi-cluster-gateways"
    spokes:
      local-cluster: {}

@pehala pehala force-pushed the improve_settings branch 2 times, most recently from e861129 to b2fd870 Compare November 8, 2023 11:52
@averevki
Copy link
Contributor

averevki commented Nov 8, 2023

I was thinking about control_plane.enabled: true flag instead of marking every mgc test (I'm open to creating PR after this is merged). What do you think?

@pehala
Copy link
Contributor Author

pehala commented Nov 8, 2023

I was thinking about control_plane.enabled: true flag instead of marking every mgc test (I'm open to creating PR after this is merged). What do you think?

I think we will use a different "smarter" way of marking them. I would like to keep the commandline switch

@pehala pehala force-pushed the improve_settings branch 2 times, most recently from bb017a7 to 17e343a Compare November 15, 2023 09:20
jsmolar
jsmolar previously approved these changes Nov 15, 2023
testsuite/tests/kuadrant/authorino/conftest.py Outdated Show resolved Hide resolved
testsuite/config/openshift_loader.py Outdated Show resolved Hide resolved
testsuite/tests/conftest.py Show resolved Hide resolved
testsuite/config/__init__.py Outdated Show resolved Hide resolved
testsuite/tests/conftest.py Show resolved Hide resolved
testsuite/tests/mgc/conftest.py Show resolved Hide resolved
testsuite/tests/mgc/conftest.py Show resolved Hide resolved
- Better reflects currect structure of the project and components
@pehala pehala merged commit f962698 into Kuadrant:main Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants