Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix capitalizazion in test_response_condition.py test #272

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix capitalizazion in test_response_condition.py test #272

merged 1 commit into from
Nov 10, 2023

Conversation

azgabur
Copy link
Contributor

@azgabur azgabur commented Nov 9, 2023

Fix bug introduced in #214 testing wrong header name resulting in always True assert. Asserted string should be Simple because HTTP headers capitalize first letter of header name.

@azgabur azgabur requested a review from pehala November 9, 2023 15:54
@azgabur azgabur mentioned this pull request Nov 9, 2023
Merged
@pehala pehala merged commit fba5d9c into Kuadrant:main Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averevki averevki averevki approved these changes

@pehala pehala pehala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azgabur @pehala @averevki