Responses section refactor #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azgabur
force-pushed
the
responses_refactor2
branch
from
e1945bf to
d252575
Compare
pehala
approved these changes
Nov 14, 2023
jsmolar
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @pehala this PR refactores Responses section and usage to closer mimic real AuthConfig/AuthPolicy structure. There are 4(+1) functions in authorization object now:
authorization.responses.add_success_header()- Add response as headerauthorization.responses.add_success_dynamic()- Add response as dynamic Envoy metadataThese functions use dataclasses contain different types of responses
JsonResponse, PlainResponse, WristbandResponseset_unauthenticated()set_unauthorized()These functions use dataclass
DenyResponseThe usage of
authorization.responses.add_simplewas not changed.