Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capabilities #288

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Add capabilities #288

merged 3 commits into from
Feb 7, 2024

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Nov 20, 2023 •
edited
Loading

Summary

  • Add marks for authorino, limitador, kuadrant, mgc, standalone, which serve both as metadata to select tests and a way how to skip if the requires setup is not present
  • Add option --enforce which fails the test if the required setup is not present instead of a skip
  • Add makefile options to select tests based on those marks
  • Remove --mgc mark
  • Annotate all tests
  • Rename gateway_api option to standalone and use inverted values
    • Makes naming more consistent

Fixes #164

@pehala pehala force-pushed the capabilities branch 2 times, most recently from 351885c to d4744b5 Compare November 22, 2023 17:45
@pehala pehala requested review from ficap and jsmolar November 22, 2023 17:46
@pehala pehala marked this pull request as ready for review November 22, 2023 17:46
@pehala
Copy link
Contributor Author

pehala commented Nov 27, 2023

Moving this to draft as the proposed solution of checking capabilities is sometimes now ran first.

@pehala pehala marked this pull request as draft November 27, 2023 12:45
@pehala pehala force-pushed the capabilities branch 2 times, most recently from 8a4d59f to 4f9a346 Compare January 29, 2024 10:39
@pehala pehala marked this pull request as ready for review January 29, 2024 10:40
averevki
averevki reviewed Jan 31, 2024
View reviewed changes
testsuite/capabilities.py Outdated Show resolved Hide resolved
testsuite/capabilities.py Outdated Show resolved Hide resolved
testsuite/capabilities.py Outdated Show resolved Hide resolved
testsuite/tests/kuadrant/authorino/metrics/conftest.py Outdated Show resolved Hide resolved
testsuite/utils.py Outdated Show resolved Hide resolved
testsuite/tests/kuadrant/authorino/operator/clusterwide/test_all_namespace_api_key.py Outdated Show resolved Hide resolved
zkraus
zkraus reviewed Feb 1, 2024
View reviewed changes
testsuite/capabilities.py Outdated Show resolved Hide resolved
jsmolar
jsmolar reviewed Feb 7, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
jsmolar
jsmolar previously approved these changes Feb 7, 2024
View reviewed changes
pehala added 3 commits February 7, 2024 14:35
@pehala
Introduce Capabilities
39a4919 
- Rename gateway_api option to standalone
@pehala
Annotate tests
b3b8157
@pehala
Add new targets to Makefile
66d06ce 
- Based on capabilities
@pehala pehala merged commit 0e033fc into Kuadrant:main Feb 7, 2024
2 checks passed
@averevki averevki mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkraus zkraus zkraus left review comments

@averevki averevki averevki approved these changes

@ficap ficap ficap approved these changes

@jsmolar jsmolar jsmolar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Capabilities
5 participants
@pehala @zkraus @jsmolar @ficap @averevki