Add logical operations on Patterns and Named patterns + new test #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pehala
reviewed
Nov 24, 2023
testsuite/tests/kuadrant/authorino/conditions/test_patternref_expressions.py
Outdated
Show resolved
Hide resolved
pehala
reviewed
Nov 27, 2023
azgabur
force-pushed
the
patterns
branch
2 times, most recently
from
7d5229a to
edb9536
Compare
averevki
reviewed
Dec 6, 2023
testsuite/tests/kuadrant/authorino/identity/extended_properties/test_token_normalization.py
Show resolved
Hide resolved
|
^ rebased solving merge conflict |
pehala
approved these changes
Dec 11, 2023
averevki
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
RuletoPatternto better reflect the real use.AnyPatternsandAllPatternswhich serve as logical operators OR and AND for Patterns.add_patterns()which adds named patterns that can be referenced withPatternRef.This PR is prerequisite before starting to work on issue #234