Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http package name collision #298

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

averevki
Copy link
Contributor

Bug

Can't call pycharm debuger inside authorino.operator package because of name collision with http.client (authorino.operator also have package named http containing tests for raw http requests)

Solution

Rename http package to http_

Note

This is conventional renaming for the name clashing. I'm open to other propositions

@averevki averevki added the bug Something isn't working label Nov 28, 2023
@averevki averevki requested a review from pehala November 28, 2023 19:34
@averevki averevki self-assigned this Nov 28, 2023
@pehala
Copy link
Contributor

pehala commented Nov 28, 2023

The proper solution is to also the working directory, but if you really want to rename it, I would liked more if you choose a better name

@pehala pehala removed the bug Something isn't working label Nov 29, 2023
@averevki averevki force-pushed the fix-http-name-clashing branch from dbb2763 to d3724a9 Compare November 29, 2023 13:58
@averevki
Copy link
Contributor Author

The proper solution is to also the working directory, but if you really want to rename it, I would liked more if you choose a better name

After consideration, I changed it to raw_http, which also, I believe, would be a better name for this package

@averevki averevki added the refactor Refactor with same functionality label Nov 29, 2023
@pehala pehala merged commit 43db72e into Kuadrant:main Dec 4, 2023
2 checks passed
@averevki averevki deleted the fix-http-name-clashing branch November 11, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor with same functionality
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants