Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary identities management #299

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Remove unnecessary identities management #299

merged 1 commit into from
Dec 4, 2023

Conversation

averevki
Copy link
Contributor

Changes explanation

  • Identities are already cleared out on the identity package level, so additional clear-out is not needed
  • Oidc identity is already applied by default on the authorino package level to the AuthConfig/AuthPolicy. Other kuadrant packages don't take advantage of the rhsso identity features

@averevki averevki added the refactor Refactor with same functionality label Nov 28, 2023
@averevki averevki requested a review from pehala November 28, 2023 22:04
@averevki averevki self-assigned this Nov 28, 2023
@averevki averevki mentioned this pull request Nov 29, 2023
Merged
@pehala pehala merged commit 55e1450 into Kuadrant:main Dec 4, 2023
2 checks passed
@averevki averevki deleted the remove-unnecessary-identities-manipulations branch November 11, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azgabur azgabur azgabur approved these changes

@pehala pehala pehala approved these changes

Assignees

@averevki averevki

Labels
refactor Refactor with same functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@averevki @pehala @azgabur