Add limit reset test #304
Merged
Add limit reset test #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my opinion limit reset is covered enough in multiple iterations test. I like limits duration change though 👍 |
pehala
reviewed
Dec 6, 2023
jsmolar
force-pushed
the
rate_limit_auth
branch
from
191ea39 to
349608b
Compare
averevki
approved these changes
Dec 7, 2023
pehala
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you think this test is needed? We test limit reset in multiple iterations.
In addition, I decreased the duration of limits by 5 sec (This decreases the runtime of this module by 60sec total).