Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test DNSPolicy health check additional headers #310

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

averevki
Copy link
Contributor

@averevki averevki commented Dec 20, 2023

Test case

DNSPolicy health check additional headers

Changes

  • Add MockserverBackend object
  • Add request expectation to the mockserver
  • Add test for DNSPolicy health check additional headers

closes #252

@averevki averevki requested a review from ficap December 20, 2023 18:12
@averevki averevki self-assigned this Dec 20, 2023
@averevki averevki added the Test case New test case label Dec 20, 2023
Copy link
Contributor

@pehala pehala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall too many changes for one additional test only due to a refactor. I would prefer to do a separate PR for the rename or keep the name for now

testsuite/mockserver.py Outdated Show resolved Hide resolved
testsuite/mockserver.py Outdated Show resolved Hide resolved
@averevki averevki force-pushed the test-health-check-header branch 2 times, most recently from 35a79b4 to 58e24e3 Compare December 22, 2023 19:01
@pehala pehala marked this pull request as draft January 23, 2024 13:45
@averevki averevki force-pushed the test-health-check-header branch from 58e24e3 to b8d7ae5 Compare January 24, 2024 17:47
@averevki averevki marked this pull request as ready for review January 24, 2024 17:49
@averevki averevki requested a review from pehala January 24, 2024 17:49
testsuite/mockserver.py Outdated Show resolved Hide resolved
testsuite/mockserver.py Outdated Show resolved Hide resolved
@averevki averevki force-pushed the test-health-check-header branch 3 times, most recently from 7f1de0c to 7ffb530 Compare January 29, 2024 12:09
@averevki averevki force-pushed the test-health-check-header branch from 7ffb530 to 4bb7e6c Compare February 13, 2024 09:07
@averevki
Copy link
Contributor Author

rebase^

@pehala pehala self-requested a review February 19, 2024 08:14
testsuite/openshift/backend.py Outdated Show resolved Hide resolved
testsuite/openshift/deployment.py Outdated Show resolved Hide resolved
testsuite/mockserver.py Outdated Show resolved Hide resolved
@averevki averevki force-pushed the test-health-check-header branch 4 times, most recently from 8d7a0d3 to 06e4642 Compare February 22, 2024 16:22
@averevki
Copy link
Contributor Author

rebase^

@averevki averevki requested review from martinhesko and azgabur March 5, 2024 10:02
@martinhesko
Copy link
Contributor

I tried running this myself but ran into some issues with DNSHealthCheckProbe not having any status. First only on gcp, later runs on both DNS providers

@averevki averevki force-pushed the test-health-check-header branch from 06e4642 to 6c05aed Compare March 5, 2024 15:57
@averevki
Copy link
Contributor Author

averevki commented Mar 5, 2024

rebase^

@martinhesko
Copy link
Contributor

Reran after rebase, working as expected now.

@pehala pehala merged commit db938e0 into Kuadrant:main Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test case New test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for DNSPolicy additionalHeadersRef
3 participants