-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Route Select for Rate Limit #316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pehala
reviewed
Jan 8, 2024
ficap
reviewed
Jan 8, 2024
jsmolar
force-pushed
the
rate_limit_auth
branch
from
January 8, 2024 15:45
a9bd463
to
4709c66
Compare
pehala
reviewed
Jan 8, 2024
jsmolar
force-pushed
the
rate_limit_auth
branch
2 times, most recently
from
January 8, 2024 15:56
3097eea
to
6649ce0
Compare
jsmolar
force-pushed
the
rate_limit_auth
branch
from
January 8, 2024 16:06
6649ce0
to
c53f359
Compare
ficap
reviewed
Jan 8, 2024
pehala
reviewed
Jan 9, 2024
jsmolar
force-pushed
the
rate_limit_auth
branch
from
January 9, 2024 19:46
2c9c4a3
to
237a1e2
Compare
pehala
approved these changes
Jan 9, 2024
averevki
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is this a setup for tests in the feature PR, or do you want to also add them here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates two new sets of objects:
RouteSelect
: https://docs.kuadrant.io/kuadrant-operator/doc/reference/route-selectors/#routeselectorHTTP Route Matchers
: https://gateway-api.sigs.k8s.io/reference/spec/#gateway.networking.k8s.io/v1.HTTPRouteMatchThe placement of these resources can be discussed as I was not 100% sure.
Tests will be added later to this PR.
Usage example: