Unify exposers #347
Merged
Unify exposers #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pehala
force-pushed
the
unite_exposers
branch
4 times, most recently
from
30b7a77 to
3a8b421
Compare
pehala
force-pushed
the
unite_exposers
branch
2 times, most recently
from
10eb276 to
4a1ee80
Compare
averevki
reviewed
Feb 28, 2024
pehala
force-pushed
the
unite_exposers
branch
2 times, most recently
from
40e1a5a to
23e4b65
Compare
averevki
previously approved these changes
Mar 14, 2024
averevki
previously approved these changes
Apr 9, 2024
averevki
previously approved these changes
Apr 12, 2024
averevki
previously approved these changes
Apr 16, 2024
jsmolar
previously approved these changes
Apr 16, 2024
ficap
previously approved these changes
Apr 16, 2024
- Add both passthrough and verify as arguments to Exposer - Require singular constructor - Tie base_domain to exposer - Allow specifying default_exposer and managedzone in settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base_domainto exposerbase_domainfunctionality toDNSPolicyExposermanagedzoneis configurable from settingsdefault_exposerin settingsopenshiftis a valid choice, MGC and Kind will come in subsequent PRs