Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metrics tests #360

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix metrics tests #360

merged 1 commit into from
Apr 9, 2024

Conversation

averevki
Copy link
Contributor

@averevki averevki commented Mar 6, 2024 •
edited
Loading

Changes:

  • Fix assert on deep-metrics tests
  • Increase wait for metrics scrape
  • Make a fixture that checks metrics availability on the cluster to run before other fixtures
  • Add explicit id's on deep-metrics tests

@averevki averevki added the enhancement Improvement to existing test label Mar 6, 2024
@averevki averevki requested a review from pehala March 6, 2024 10:04
@averevki averevki self-assigned this Mar 6, 2024
@averevki averevki force-pushed the fix-metrics-assert branch from ab146ae to d133e68 Compare March 6, 2024 13:47
@averevki averevki changed the title Fix metrics assert Fix metrics tests Mar 6, 2024
@averevki averevki force-pushed the fix-metrics-assert branch from d133e68 to 4b0d35e Compare March 6, 2024 23:42
@averevki averevki marked this pull request as draft March 6, 2024 23:56
@averevki averevki marked this pull request as ready for review March 21, 2024 10:26
@averevki averevki requested review from martinhesko and azgabur March 21, 2024 10:27
@averevki averevki force-pushed the fix-metrics-assert branch from 4b0d35e to 5c5c927 Compare March 27, 2024 16:05
@averevki
Copy link
Contributor Author

^rebase

@martinhesko
Copy link
Contributor

Tested this locally, ServiceMonitor gets deleted as expected, all the changes seem reasonable, LGTM on my side

@averevki averevki merged commit 7e72827 into Kuadrant:main Apr 9, 2024
2 checks passed
@pehala pehala mentioned this pull request Apr 10, 2024
Merged
@averevki averevki deleted the fix-metrics-assert branch November 11, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pehala pehala pehala approved these changes

@martinhesko martinhesko martinhesko approved these changes

@azgabur azgabur Awaiting requested review from azgabur

Assignees

@averevki averevki

Labels
enhancement Improvement to existing test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@averevki @martinhesko @pehala