Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gateway fixture session scope #362

Closed
wants to merge 1 commit into from
Closed

Make gateway fixture session scope #362

wants to merge 1 commit into from

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Mar 6, 2024

  • Solves problems with limitador test concurrency failures
  • Increases time for running individual tests but doesn't change overall test time even if load balancers take a while
  • individual tests still can use module scope GW
    • MGC still uses it

Thanks @azgabur for investigating!

@pehala pehala requested review from jsmolar, averevki and azgabur March 6, 2024 15:46
averevki
averevki reviewed Mar 11, 2024
View reviewed changes
testsuite/tests/conftest.py Outdated
)
request.addfinalizer(gw.delete)
gw.commit()
gw.wait_for_ready(timeout=20 * 60)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20 minutes probably a mistake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not, if run with -n4 the load balancers will be created in sequence and thus will take 4 times the amount (maybe more) than we are used to. I put 20 minutes as an overkill number, so I can lower it to 10 if required, but this was to be just safe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I would test what approximate time it requires then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can test it now, but there is no guarantee that it will stay that way, due to the instability of OpenStack

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20 minutes seems too long for the test to not work at all at the end because of the load balancer...

@pehala pehala closed this Mar 11, 2024
@pehala pehala mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averevki averevki averevki left review comments

@jsmolar jsmolar Awaiting requested review from jsmolar

@azgabur azgabur Awaiting requested review from azgabur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pehala @averevki