Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparison dashboard #562

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Add comparison dashboard #562

merged 2 commits into from
Nov 7, 2024

Conversation

david-martin
Copy link
Member

@david-martin david-martin commented Oct 18, 2024

This is similar to the main dashboard, expect you can choose 2 UUIDs to compare.
The comparison is side by side for cpu, memory and reconcile time, with a calculated diff (and colouring for +/-)
I deliberately left out aggregations by pod comparisons as the pod names can be different. The namespaces are the same between runs, so they are less likely to cause issues with the panels when doing joining and transforms.

image

Signed-off-by: David Martin <[email protected]>
@david-martin david-martin requested a review from trepel October 18, 2024 13:47
@trepel
Copy link
Contributor

trepel commented Oct 21, 2024

/approve

@david-martin
Copy link
Member Author

@trepel I've pushed an update to take the average value for cpu & memory rather than just the most recent value. I think this will give a better representation of usage.
I used this approach for the related comparison script pr #564 as well.

Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did run this in local Grafana, the Dashboard looks good to me.

@trepel trepel merged commit 4cc795d into main Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants