D&O merged policies / sectionName tests #608
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Hesko <[email protected]>
Signed-off-by: Martin Hesko <[email protected]>
Signed-off-by: Martin Hesko <[email protected]>
Allow adding strategy field to policies. Signed-off-by: Jim Fitzpatrick <[email protected]>
Signed-off-by: Martin Hesko <[email protected]>
This adds test that make use of the merge strategy on defaults that are targeting the same resource. Signed-off-by: Jim Fitzpatrick <[email protected]>
This adds test that make use of the merge strategy on overrides that are targeting the same resource. Signed-off-by: Jim Fitzpatrick <[email protected]>
Add missing doc string to conftest.py Signed-off-by: Jim Fitzpatrick <[email protected]>
martinhesko
commented
Dec 16, 2024
| CelPredicate("request.path == '/anything'"), | ||
| ] | ||
| policy.overrides.add_limit("basic", [OVERRIDE_LIMIT], when=basic_when) | ||
| policy.overrides.add_limit("override", [OVERRIDE_LIMIT], when=override_when) |
There was a problem hiding this comment.
@Boomatang in this case there is functionally no difference between the two related tests, I would suggest reworking this with 2 normal limits and 1 override in this policy to apply the partial override in one case, similar to how it works in overrides/merge/test_gateway_override_merge.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #600 first as the section_names commits are present in both