Add tests for changing targetRef field in policies #641
Conversation
...ts/singlecluster/gateway/reconciliation/change_targetref/test_update_tlspolicy_target_ref.py
Outdated
Show resolved
Hide resolved
...ts/singlecluster/gateway/reconciliation/change_targetref/test_update_tlspolicy_target_ref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/change_targetref/conftest.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/change_targetref/conftest.py
Outdated
Show resolved
Hide resolved
...ts/singlecluster/gateway/reconciliation/change_targetref/test_update_dnspolicy_target_ref.py
Outdated
Show resolved
Hide resolved
...ts/singlecluster/gateway/reconciliation/change_targetref/test_update_dnspolicy_target_ref.py
Outdated
Show resolved
Hide resolved
...ts/singlecluster/gateway/reconciliation/change_targetref/test_update_tlspolicy_target_ref.py
Outdated
Show resolved
Hide resolved
Signed-off-by: emmaaroche <[email protected]>
emmaaroche
force-pushed
the
change-targetref-tests
branch
from
895c6e6 to
8e86700
Compare
| client2 = hostname2.client() | ||
|
|
||
| response = client2.get("/get") | ||
| assert not response.has_cert_verify_error() | ||
| assert not response.has_dns_error() | ||
| assert response.status_code == 200 | ||
|
|
||
| client2.close() |
There was a problem hiding this comment.
you can put second client in a separate fixture so you don't have to close it inside the test. Check out usage of yield in the pytest
There was a problem hiding this comment.
For this, I chose to initialize client2 only after the targetRef change to ensure the TLS secret is available. When using a separate client2 fixture, errors occurred due to missing TLS certificates.
| response = client.get("/get") | ||
| assert not response.has_cert_verify_error() | ||
| assert not response.has_dns_error() | ||
| assert response.status_code == 200 | ||
|
|
There was a problem hiding this comment.
please also verify that second gateway is not affected by tls/dns policies with requests before the change. Statuses change you asserted above isn't enough, it may show that it's not affected but be different in practice
| response = client2.get("/get") | ||
| assert not response.has_cert_verify_error() | ||
| assert not response.has_dns_error() | ||
| assert response.status_code == 200 | ||
|
|
There was a problem hiding this comment.
same but with the first gateway. Check that it's not affected anymore
Summary
This PR adds reconciliation tests focusing on targetRef updates across different policies.
Test Cases Covered
targetReffrom Gateway 1 (hostname 1) to Gateway 2 (hostname 2).targetReffrom Gateway 1 (hostname 1) to Gateway 2 (hostname 2).Additional Notes
testsuite/tests/singlecluster/gateway/reconciliation/change_targetref/conftest.pyto use TLSGatewayListener instead of GatewayListener.testsuite/tests/singlecluster/gateway/reconciliation/change_targetref/conftest.py.Related Issue
Closes #307