Fix calling next operation when error #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didierofrivia
changed the title
handle_error_on_grpc_response
didierofrivia
force-pushed
the
fix-calling-next
branch
3 times, most recently
from
150fda4 to
b53bbda
Compare
src/service/rate_limit.rs
Outdated
| } | ||
| _ => {} | ||
| _ => Err(StatusCode::InternalServerError), |
There was a problem hiding this comment.
I'm wondering about this case here, this is the fall through for the matches above - if we always expect the above should we do GrpcService::handle_error_on_grpc_response(failure_mode); as well, similar to the auth case?
adam-cattermole
approved these changes
Oct 8, 2024
Signed-off-by: dd di cesare <[email protected]>
* We can later check on the actual status to make decisions Signed-off-by: dd di cesare <[email protected]>
didierofrivia
force-pushed
the
fix-calling-next
branch
from
b53bbda to
7f22481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.