Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move selectors to expressions in dev environment #141

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Move selectors to expressions in dev environment #141

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4472c4b
Move selectors to expressions in dev environment
adam-cattermole Nov 12, 2024
cc5fa59
The request.headers should be lowercase
adam-cattermole Nov 12, 2024
ae16bb3
Debug log request.headers map
adam-cattermole Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions utils/deploy/envoy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,9 @@ data:
"scope": "rlp-ns-A/rlp-name-A",
"data": [
{
"selector": {
"selector": "unknown.path"
"expression": {
"key": "unknown.path",
"value": "unknown.path"
}
}
]
Expand Down Expand Up @@ -237,19 +238,21 @@ data:
}
},
{
"selector": {
"selector": "source.address"
"expression": {
"key": "source.address",
"value": "source.address"
}
},
{
"selector": {
"selector": "request.headers.My-Custom-Header-01"
"expression": {
"key": "request.headers['My-Custom-Header-01']",
"value": "request.headers['My-Custom-Header-01']"
}
},
{
"selector": {
"selector": "metadata.filter_metadata.envoy\\.filters\\.http\\.header_to_metadata.user_id",
"key": "user_id"
"expression": {
"key": "user_id",
"value": "string(getHostProperty(['metadata', 'filter_metadata', 'envoy.filters.http.header_to_metadata', 'user_id']))"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be auth.somthing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this one is coming from the header_to_metadata filter proving we can get filter state from non-kuadrant filters

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what would be required if the auth step is configured using gateway capabilities like Security Policy (but not used for ext auth service, but jwt for instance.

}
}
]
Expand Down Expand Up @@ -278,8 +281,9 @@ data:
"scope": "rlp-ns-D/rlp-name-D",
"data": [
{
"selector": {
"selector": "source.remote_address"
"expression": {
"key": "source.remote_address",
"value": "source.remote_address"
}
}
]
Expand Down
Loading