Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not resume on failure #158

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Do not resume on failure #158

merged 4 commits into from
Dec 5, 2024

Conversation

adam-cattermole
Copy link
Member

@adam-cattermole adam-cattermole commented Dec 4, 2024

Workaround for FailureMode propagation before we complete the refactor

Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
@adam-cattermole adam-cattermole force-pushed the failure-mode-propagation branch from 84d702a to c9cc4dc Compare December 4, 2024 17:43
@adam-cattermole adam-cattermole marked this pull request as ready for review December 4, 2024 17:44
@adam-cattermole adam-cattermole requested a review from a team as a code owner December 4, 2024 17:45
Copy link
Contributor

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Adam Cattermole <[email protected]>
@adam-cattermole adam-cattermole linked an issue Dec 5, 2024 that may be closed by this pull request
@adam-cattermole adam-cattermole self-assigned this Dec 5, 2024
@adam-cattermole adam-cattermole added the bug Something isn't working label Dec 5, 2024
@adam-cattermole adam-cattermole merged commit 2868f20 into main Dec 5, 2024
13 checks passed
@adam-cattermole adam-cattermole deleted the failure-mode-propagation branch December 5, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

FailureMode propagation and handling in services
2 participants