Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish binary on release #51

Merged
merged 1 commit into from
Apr 29, 2024
Merged

publish binary on release #51

merged 1 commit into from
Apr 29, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Apr 23, 2024 •
edited
Loading

What

GH Action to publish binary on release

Screenshot 2024-04-23 at 13-18-04 Kuadrant_wasm-shim A Proxy-Wasm module allowing communication to Authorino and Limitador

$ wget https://github.com/Kuadrant/wasm-shim/releases/download/v0.4.0-alpha.1/kuadrant-ratelimit-wasm-v0.4.0-alpha.1
--2024-04-23 13:12:44--  https://github.com/Kuadrant/wasm-shim/releases/download/v0.4.0-alpha.1/kuadrant-ratelimit-wasm-v0.4.0-alpha.1
Resolving github.com (github.com)... 140.82.121.3
Connecting to github.com (github.com)|140.82.121.3|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://objects.githubusercontent.com/github-production-release-asset-2e65be/431402609/5f75a373-1bbc-4d12-b550-f9f0b2e148fa?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20240423%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240423T111226Z&X-Amz-Expires=300&X-Amz-Signature=23e5bf853b0ebe707739e5acc63cd93a041897abb9a1a72585f5ea7d3ca0ad3a&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=431402609&response-content-disposition=attachment%3B%20filename%3Dkuadrant-ratelimit-wasm-v0.4.0-alpha.1&response-content-type=application%2Foctet-stream [following]
--2024-04-23 13:12:44--  https://objects.githubusercontent.com/github-production-release-asset-2e65be/431402609/5f75a373-1bbc-4d12-b550-f9f0b2e148fa?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20240423%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240423T111226Z&X-Amz-Expires=300&X-Amz-Signature=23e5bf853b0ebe707739e5acc63cd93a041897abb9a1a72585f5ea7d3ca0ad3a&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=431402609&response-content-disposition=attachment%3B%20filename%3Dkuadrant-ratelimit-wasm-v0.4.0-alpha.1&response-content-type=application%2Foctet-stream
Resolving objects.githubusercontent.com (objects.githubusercontent.com)... 185.199.109.133, 185.199.110.133, 185.199.111.133, ...
Connecting to objects.githubusercontent.com (objects.githubusercontent.com)|185.199.109.133|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 2619099 (2,5M) [application/octet-stream]
Saving to: ‘kuadrant-ratelimit-wasm-v0.4.0-alpha.1’

kuadrant-ratelimit-wasm-v0.4.0-alpha.1                               100%[=====================================================================================================================================================================>]   2,50M  --.-KB/s    in 0,1s    

2024-04-23 13:12:45 (18,9 MB/s) - ‘kuadrant-ratelimit-wasm-v0.4.0-alpha.1’ saved [2619099/2619099]

$ file kuadrant-ratelimit-wasm-v0.4.0-alpha.1 
kuadrant-ratelimit-wasm-v0.4.0-alpha.1: WebAssembly (wasm) binary module version 0x1 (MVP)

@eguzki eguzki requested a review from didierofrivia April 23, 2024 11:20
didierofrivia
didierofrivia reviewed Apr 23, 2024
View reviewed changes
.github/workflows/release.yaml
profile: minimal
toolchain: stable
override: true
target: wasm32-unknown-unknown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we provide the targets as matrix? arm, amd, etc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be wasm always!

@eguzki eguzki requested a review from didierofrivia April 24, 2024 14:12
didierofrivia
didierofrivia approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧇

didierofrivia
didierofrivia reviewed Apr 29, 2024
View reviewed changes
.github/workflows/release.yaml
@@ -0,0 +1,36 @@
---

name: Release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the near future we could include in the same workflow the release of the images as well. since this is just the building the binary

@eguzki eguzki merged commit 041c9a7 into main Apr 29, 2024
5 checks passed
@eguzki eguzki deleted the publish-binary-on-release branch April 29, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didierofrivia didierofrivia didierofrivia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eguzki @didierofrivia