wasm binary version enhanced traces #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Generates log line with traceable version of the wasm module
Format being:
Rules for <VERSION>
main
branch no longer has meaninglessv0.1.0
. It hasv<next-unreleased-version>-dev
. So if the current release isv0.4.0
, Cargo.toml file would have something like thisthat
dev
suffix means it is still under development.The v0.5.0 release process would have an extra step to bump the version to
version = "v0.5.0"
and main would be bumped toVersion = "v0.6.0-dev"
Rules for <GIT_HASH>
The build process first tries
if it succeeded, it tries to check for "dirty" files (not committed files used in the build)
So
GIT_HASH
is eitheror
If it fails (because there is no
git
in the build process), it tries to read env varGITHUB_SHA
, soIt fallsback to
NO_SHA
when even theGITHUB_SHA
env var does not exist.These rules are implemented in https://github.com/Kuadrant/limitador
Verification steps
The output should be something like
highlighting here the important bits:
Kuadrant wasm module v0.5.0-dev (7ea94e90) ["+with-serde"] release
The output should be something like
highlighting here the important bits:
Kuadrant wasm module v0.5.0-dev (7ea94e90-dirty) ["+with-serde"] release
GITHUB_SHA=v10.0.0
🚨 make sure your git repo does not have anything pending to be pushed. It is better to follow these steps on a just cloned repo.
The output should be something like
highlighting here the important bits:
Kuadrant wasm module v0.5.0-dev (v10.0.0) ["+with-serde"] release