Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial implementation of auth service #69

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

adam-cattermole
Copy link
Member

@adam-cattermole adam-cattermole commented Aug 16, 2024

Changes

  • Refactor of the ratelimit service and auth services into a generic GrpcServiceHandler
  • Addition of the new HeaderResolver which is passed into each GrpcServiceHandler to ensure the headers are only retrieved once (and set in a OnceCell)
  • For now the Auth and RL services are only used to create the messages and could be moved to an alternative location (for now auth marked as dead code until used)
  • Fixed the integration test order of hostcalls and removed for the tests where there are no longer retrieval of headers

Base automatically changed from refactoring-2 to main August 20, 2024 15:21
@adam-cattermole adam-cattermole force-pushed the authservice branch 7 times, most recently from e095600 to 69c15d6 Compare August 21, 2024 14:07
@adam-cattermole adam-cattermole changed the base branch from main to external-auth August 22, 2024 13:15
@adam-cattermole adam-cattermole force-pushed the authservice branch 3 times, most recently from 08bf3f1 to 5f274ba Compare August 28, 2024 14:09
@adam-cattermole adam-cattermole marked this pull request as ready for review August 28, 2024 14:29
Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍸

@adam-cattermole adam-cattermole merged commit 870cafd into external-auth Aug 28, 2024
8 checks passed
@adam-cattermole adam-cattermole deleted the authservice branch August 28, 2024 15:30
@didierofrivia didierofrivia mentioned this pull request Oct 1, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants