Refactoring actions #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Building the descriptors are not relying on Filter anymore * Getting the properties for the descriptors directly using `hostcalls::get_property` * Since Filter is not passed, we are not logging `context_id` anymore Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: dd di cesare <[email protected]>
|
Closing this one, changes already migrated to #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is yet another step closer to get #58 done.
Now
Actionsreside within a givenRule. The logic behind this change is that actions are dependant of the rule that matches, and not a set of actions for all of them.Filteranymorehostcalls::get_propertydirectlyNotes:
Filteranymore for building the descriptors, we are not logging thecontext_idwhen getting de properties.