Implement texture handling for BlockItemBuilder texture overrides #868
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BlockItemBuilder
s ignore texture overrides provided via the.texture
method, preventing scripters from changing a block item's texture without a workaround. See https://discord.com/channels/303440391124942858/1098748984572518440 . This fix attempts to mimic the behavior ofItemBuilder
which handles this data correctly, but itsgenerateAssetJsons
method is overridden byBlockItemBuilder
.Example Script
Other details
I'm very new to this codebase and MC modding in general so there is probably something I've overlooked :)