Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add certgenerator ut, exclude more pkg for make cover #651

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

elliotxx
Copy link
Collaborator

What type of PR is this?

/kind test

What this PR does / why we need it:

This PR adds unit tests for the certgenerator module and excludes more packages from the make cover command to improve code coverage analysis.

Which issue(s) this PR fixes:

Fixes #

@elliotxx elliotxx added this to the v0.6.0 milestone Nov 25, 2024
@elliotxx elliotxx self-assigned this Nov 25, 2024
Copy link
Collaborator

@ruquanzhao ruquanzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@elliotxx elliotxx merged commit 0706882 into main Nov 25, 2024
8 checks passed
@elliotxx elliotxx deleted the add-certgenerator-ut branch November 25, 2024 10:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants