Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kusion release show command #1265

Merged
merged 1 commit into from
Aug 19, 2024
Merged

feat: add kusion release show command #1265

merged 1 commit into from
Aug 19, 2024

Conversation

hoangndst
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

This command displays detailed information about a release of the current project in the current or a specified workspace.

Which issue(s) this PR fixes:

Fixes #1262

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@hoangndst
Copy link
Collaborator Author

hoangndst commented Aug 11, 2024

About the flag --resource-id I think it should be in kusion resource command. In my point of view, it is not an overlap in functionality.

  • kusion release command shows the release of the project in the workspace.
  • kusion resource command shows the resource applied in a workspace or project and shows the specific resource detail. kusion resource may help the user get resources details including id to add to imported source spec in the workspace (this can be in kusion resource add command).
    cc @liu-hm19 @ffforest

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10341865950

Details

  • 96 of 134 (71.64%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 52.66%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/release/show.go 95 133 71.43%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
Totals Coverage Status
Change from base Build 10302040287: 0.1%
Covered Lines: 8830
Relevant Lines: 16768

💛 - Coveralls

@liu-hm19
Copy link
Contributor

@hoangndst Hi! I'm sorry for the delayed response because I've been on vacation these days. I will make time to review this PR ASAP. Thanks a lot for your passionate contribution! 🥇

Regarding the kusion resource sub-command, I think this is quite a reasonable idea, but since Kusion's design philosophy is application-centric, we may need to confirm with other members of the community whether it is compatible to provide the ability to manage a single resource. cc @SparkYuan @ffforest

@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Aug 19, 2024
@adohe adohe added this to the v0.13.0 milestone Aug 19, 2024
@liu-hm19 liu-hm19 self-requested a review August 19, 2024 03:38
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit c29980d into KusionStack:main Aug 19, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: add a new command kusion release show
4 participants