Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kusion module apis for server #1310

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Nov 8, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds the implementation of module-related apis for kusion server.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Nov 8, 2024
@liu-hm19 liu-hm19 self-assigned this Nov 8, 2024
@coveralls
Copy link

coveralls commented Nov 11, 2024

Pull Request Test Coverage Report for Build 11771802255

Details

  • 32 of 302 (10.6%) changed or added relevant lines in 10 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 51.491%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/infra/persistence/util.go 0 3 0.0%
pkg/server/route/route.go 12 15 80.0%
pkg/domain/entity/module.go 0 5 0.0%
pkg/domain/request/module_request.go 0 6 0.0%
pkg/infra/persistence/module_model.go 0 41 0.0%
pkg/infra/persistence/module.go 0 62 0.0%
pkg/server/handler/module/handler.go 10 81 12.35%
pkg/server/manager/module/module_manager.go 0 79 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/infra/persistence/util.go 1 71.62%
pkg/cmd/destroy/destroy.go 7 42.55%
Totals Coverage Status
Change from base Build 11676751829: -0.7%
Covered Lines: 10463
Relevant Lines: 20320

💛 - Coveralls

Copy link
Contributor

@ffforest ffforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 21b0d49 into KusionStack:main Nov 11, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants