Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update install.sh for MacOs&linux, and add uninstall.sh #303

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

healthjyk
Copy link
Contributor

@healthjyk healthjyk commented Sep 22, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

kusion issue#555

2. What is the scope of this PR (e.g. component or file name):

static/scripts

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Already tested, as follows:
image
image
image

@healthjyk healthjyk self-assigned this Sep 22, 2023
@healthjyk healthjyk added bug Something isn't working documentation Improvements or additions to documentation labels Sep 22, 2023
@healthjyk healthjyk removed the bug Something isn't working label Sep 22, 2023
@SparkYuan
Copy link
Member

@healthjyk What is the static/scripts/deprecated-install.sh file used for? Can we delete it directly since it is deprecated?

@healthjyk
Copy link
Contributor Author

healthjyk commented Sep 25, 2023

@healthjyk What is the static/scripts/deprecated-install.sh file used for? Can we delete it directly since it is deprecated?

I think it's necessary to keep the old installation script, cause there is no version control for kusionstack.io.
Although you can find it in the commit log, but too tiring. @SparkYuan

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit c7dd6f8 into KusionStack:main Sep 25, 2023
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants