Probes are defaulted on, but can be totally overriden #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jeg ville gerne videre - Så jeg har merget - Jeg laver gerne ændringer på efterkrav! :-) |
JonasPed
reviewed
Sep 16, 2024
| timeoutSeconds: 5 | ||
| {{- toYaml .Values.kitcaddy.startupProbe | nindent 12 }} | ||
| {{- end }} | ||
| {{- if .Values.kitcaddy.readinessProbe }} | ||
| readinessProbe: |
There was a problem hiding this comment.
Nu vi er så godt i gang med at pille, burde vi ikke give mulighed for at definere en liveness probe også?
| path: /metrics | ||
| port: 80 | ||
| scheme: HTTP | ||
| initialDelaySeconds: 50 |
There was a problem hiding this comment.
Jeg synes ikke jeg oplever at det er normalt at det tager så lang tid for Kitcaddy for at være klar. Normalt plejer Kitcaddy at starte op på meget kort tid (< 1sek).
Kan det være en ting i Netic miljøet der gør at det tager så lang tid? Så synes jeg default skal være lavere, så det ikke går ud over andre anvendere af Kitcaddy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.