[Feat] 수강신청 기능 구현 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingpyo
approved these changes
Mar 26, 2024
Comment on lines
50
to
58
| public MemberShip(Long id, User student, Product product, Integer remainingCount) { | ||
| this.id = id; | ||
| this.student = student; | ||
| this.product = product; | ||
| this.remainingCount = remainingCount; | ||
| } | ||
|
|
||
| public static MemberShip of(User student, Product product, Integer remainingCount) { | ||
| return new MemberShip(null, student, product, remainingCount); |
There was a problem hiding this comment.
final 키워드로 불변성을 보장해주면 좋을거같아요
| @@ -33,4 +33,12 @@ public class Product extends BaseEntity { | |||
| private User teacher; | |||
|
|
|||
| private Integer count; | |||
|
|
|||
| public Product(Long id, String name, ProductType type, User teacher, Integer count) { | |||
| @@ -36,4 +36,13 @@ public class User extends BaseEntity { | |||
|
|
|||
| @Enumerated(EnumType.STRING) | |||
| private Identity identity; | |||
|
|
|||
| public User(Long id, String name, String deviceToken, String passWord, Gender gender, Identity identity) { | |||
| @PostMapping("/apply/{productId}") | ||
| public Long apply( | ||
| @AuthenticationPrincipal final Long userId, | ||
| @PathVariable Long productId) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
설명