request service and endpoints #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammoorhouse
requested changes
Feb 24, 2020
| @GetMapping("/api/v1/request/requester/{id}") | ||
| public List<RequestTO> getRequestByRequesterId(@PathVariable("id") Integer id) { | ||
| return this.jdbcTemplate.query( | ||
| "select * from requests where requester_id = ?", |
There was a problem hiding this comment.
don't do select *. What happens if someone comes along later and inserts or removes a column?
| public class RequestController { | ||
|
|
||
| @Autowired | ||
| JdbcTemplate jdbcTemplate; |
There was a problem hiding this comment.
are you using a DAO for this? The controller uses the DAO, the DAO uses the JdbcTemplate.
This is fine if you're not using a DAO...
| JdbcTemplate jdbcTemplate; | ||
|
|
||
| @CrossOrigin | ||
| @ApiOperation("Make a request") |
There was a problem hiding this comment.
a what request? all of these services are requests...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.