Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified query progress for KDB+ and Insights #486

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Unified query progress for KDB+ and Insights #486

merged 3 commits into from
Dec 30, 2024

Conversation

ecmel
Copy link
Collaborator

@ecmel ecmel commented Dec 26, 2024

Changes introduced by this PR

  • Unified KDB+ and Insights connection query progress, now both displays the same notification in the status bar
  • When clicked becomes a cancellable notification. Cancellation discards the results and does not display results (or plot).

@ecmel ecmel self-assigned this Dec 26, 2024
@ecmel ecmel changed the title Unified query progress for KDB+ and Insgihts Unified query progress for KDB+ and Insights Dec 26, 2024
@ecmel ecmel marked this pull request as ready for review December 26, 2024 07:21
@ecmel ecmel requested a review from nfarrell-kx December 30, 2024 10:13
nfarrell-kx
nfarrell-kx reviewed Dec 30, 2024
View reviewed changes
src/classes/insightsConnection.ts Outdated Show resolved Hide resolved
src/commands/serverCommand.ts Outdated Show resolved Hide resolved
@kx-sonarqube
Copy link

kx-sonarqube bot commented Dec 30, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
4 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ecmel ecmel requested a review from nfarrell-kx December 30, 2024 11:31
@ecmel ecmel merged commit 2280e5e into dev Dec 30, 2024
5 checks passed
@ecmel ecmel deleted the ee-progress branch December 30, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfarrell-kx nfarrell-kx nfarrell-kx approved these changes

Assignees

@ecmel ecmel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecmel @nfarrell-kx