Fixes max
, min
, prod
& sum
for keyed tables
#19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
What is the bug?
If possible please include a summary and reproducible use-case below:
Several functions from the Pandas API raise a
length
error while working over the default axis.How does the change fix it?
I think that the simplest fix is to reorder the calculation of the
cols
variable at thepreparse_computations
general method. By doing so, we get rid of the redundant keys and the result is consistent with@convert_result
. This simple change fixes allmax
,min
,prod
andsum
(and alsoany
andall
) when invoked with a keyed table and default axis.Code
Testing