Skip to content

Commit

Permalink
Merge pull request jakartaee#687 from gavinking/sigtest
Browse files Browse the repository at this point in the history
update sigtest to 2.2 everywhere
  • Loading branch information
KyleAure authored Apr 12, 2024
2 parents 2dd04fb + 2afadb2 commit 5c29667
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion tck-dist/src/main/asciidoc/data-tck-reference-guide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
:APIGitSite: https://github.com/jakartaee/data

:TCKTestPlatform: JUnit5
:SigPluginGAV: org.netbeans.tools:sigtest-maven-plugin:1.6
:SigPluginGAV: jakarta.tck:sigtest-maven-plugin:2.2

:JavaVersion1: 17
:JavaVersion2: 21
Expand Down
2 changes: 1 addition & 1 deletion tck-dist/src/main/asciidoc/sections/04prereq.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Knowledge of how these frameworks operate and interact will help during the proj

1. **Arquillian** - Version 1.7.0.Alpha13 or later - The {APILongName} TCK can run in EE Mode and it uses Arquillian to execute tests within an Arquillian "container" for certifying against an EE Platform. You must configure an https://arquillian.org/guides/developing_a_container_adapter/[Arquillian adapter] for your target runtime.
2. **JUnit5** - Version 5.9.0 or later - The {APILongName} TCK uses JUnit5 as the entry-point for tests and deployments using Arquillian.
3. **Signature Test Plugin** - Version 1.6 exactly - The {APILongName} TCK uses the Signature Test Plugin to verify API signatures used by an implementation and those release by the specification match.
3. **Signature Test Plugin** - Version 2.2 exactly - The {APILongName} TCK uses the Signature Test Plugin to verify API signatures used by an implementation and those release by the specification match.
+
No action is needed here, but we note that the signature files were built and should be validated with the plugin with group:artifact:version coordinates: **{SigPluginGAV}**, as used by the sample runner included in the TCK zip.
This is a more specific direction than in earlier releases of the platform TCK, in which it was left more open for the user to use a compatible tool.
Expand Down
4 changes: 2 additions & 2 deletions tck-dist/src/main/starter/ee-pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

<arquillian.version>1.7.0.Alpha13</arquillian.version>
<junit.version>5.9.0</junit.version>
<sigtest.version>1.6</sigtest.version>
<sigtest.version>2.2</sigtest.version>

<maven.dep.plugin.version>3.3.0</maven.dep.plugin.version>
<maven.comp.plugin.version>3.10.1</maven.comp.plugin.version>
Expand Down Expand Up @@ -108,7 +108,7 @@
</dependency>
<!-- Signature Test Plugin -->
<dependency>
<groupId>org.netbeans.tools</groupId>
<groupId>jakarta.tck</groupId>
<artifactId>sigtest-maven-plugin</artifactId>
<version>${sigtest.version}</version>
</dependency>
Expand Down
4 changes: 2 additions & 2 deletions tck-dist/src/main/starter/se-pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

<arquillian.version>1.7.0.Alpha13</arquillian.version>
<junit.version>5.9.0</junit.version>
<sigtest.version>1.6</sigtest.version>
<sigtest.version>2.2</sigtest.version>

<maven.dep.plugin.version>3.3.0</maven.dep.plugin.version>
<maven.comp.plugin.version>3.10.1</maven.comp.plugin.version>
Expand Down Expand Up @@ -93,7 +93,7 @@
</dependency>
<!-- Signature Test Plugin -->
<dependency>
<groupId>org.netbeans.tools</groupId>
<groupId>jakarta.tck</groupId>
<artifactId>sigtest-maven-plugin</artifactId>
<version>${sigtest.version}</version>
</dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This package is inherited from the Platform-TCK (https://github.com/eclipse-ee4j

The latest signature files are updated in the Jakarta Data TCK Repository
(data/tck/src/main/resources/ee/jakarta/tck/data/framework/signature)
generated using sigtest-maven-plugin.jar (version 1.6).
generated using sigtest-maven-plugin.jar (version 2.2).

The signature tests are run using the sigtest-maven-plugin.jar and the framework available in this folder.

Expand All @@ -20,7 +20,7 @@ The plugin that generates the signature file has been copied below for reference
```xml
<!-- Run signature plugin to generate signature file -->
<plugin>
<groupId>org.netbeans.tools</groupId>
<groupId>jakarta.tck</groupId>
<artifactId>sigtest-maven-plugin</artifactId>
<version>${sigtest.version}</version>
<executions>
Expand Down

0 comments on commit 5c29667

Please sign in to comment.