Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix video playback with other visuals #413

Merged
merged 10 commits into from
Jun 19, 2020
Merged

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Jun 5, 2020

Closes #358

@larsoner larsoner changed the title Fixes BUG: Fix video playback with other visuals Jun 5, 2020
@larsoner
Copy link
Member Author

larsoner commented Jun 5, 2020

@drammock this fixes a bug with video playback when other visuals are used. Can you give it a look?

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #413 into master will increase coverage by 0.01%.
The diff coverage is 80.95%.

@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
+ Coverage   88.36%   88.37%   +0.01%     
==========================================
  Files          49       50       +1     
  Lines        6582     6609      +27     
  Branches     1090     1093       +3     
==========================================
+ Hits         5816     5841      +25     
- Misses        513      514       +1     
- Partials      253      254       +1     

@larsoner
Copy link
Member Author

larsoner commented Jun 5, 2020

@LiesbethGijbels can you see if the advanced_video.py example works for you? In theory it should allow you to use expyfun video functions to show your video rather than cv2.

@larsoner
Copy link
Member Author

@drammock can you look and try this out?

@drammock
Copy link
Member

Not easily. see spatialaudio/python-rtmixer#22

@drammock
Copy link
Member

running advanced_video.py example on Linux looks good after installing pillow(which is an unstated dependency, maybe only for screenshots?). I see the video shrinking and then moving rightward, with the background color changing behind it. Keyboard button presses do not work to pause the video however.

@drammock
Copy link
Member

After setting config value RESPONSE_DEVICE to keyboard, I still can't pause the video.

@larsoner
Copy link
Member Author

I broke that bit of the example, it should be fixed now (pausing using 1. pauses things on my machine). If you get no keyboard response at all, perhaps try simple_experiment.py to see if other experiments work or not. It will tell us if the problem is specific to this example, or to expyfun/pyglet overall

@drammock
Copy link
Member

hmm, button presses not working in simple_experiment either. I've probably forgotten some dumb aspect of the setup; it's been so long since I set up a new system like this.

@larsoner
Copy link
Member Author

Make sure the window that pops up actually has focus, you might need to click on it to get it to really have focus

@drammock
Copy link
Member

you might need to click on it to get it to really have focus

yeah, I've been doing that; still no dice.

@larsoner
Copy link
Member Author

Maybe try changing Pyglet versions? pip install pyglet==1.3.2 or pyglet<1.5 to get some 1.4 variant...?

If that doesn't work, which window manager are you running? I can try to replicate. Running just from a terminal with python -i whatever.py I assume?

@drammock
Copy link
Member

downgrading to pyglet 1.4 worked!

@larsoner larsoner merged commit 4ace255 into LABSN:master Jun 19, 2020
@larsoner larsoner deleted the fixes branch June 19, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many problems with video presentation
2 participants