Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a 4k 30fps and 1080p 30 fps on Linux with:
On Linux, on
main
:fnames[0]
(4k) things are a slideshow (1-2 FPS) and I get the error reported in Unable to change window size for video playback #444fnames[1]
(1080p) things are smooth (probably the native 30 FPS) and there is no errorOn this PR, for
[0]
I get the same playback but no error, and for[1]
I get the same (good/correct) behavior as onmain
. And even when I setset_scale(0.1)
, playback is still terrible for the 4k video, suggesting that it's a video decoding/resolution limitation rather than anything having to do with the window/display size on screen (again, at least on my Linux machine!).@JustinTFleming can you try this branch and see if you observe the same behavior on Windows? (BTW, with bug reports it's usually best to come up with a minimal reproducible example like the above if possible -- it saves devs time and makes sure that everyone is comparing apples to apples, to the extent possible!)
If you do get the same behavior, then I would look into maybe making your videos have a slower framerate or resolution.
Closes #444