Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #731: add poetry-instructions dataset #1009

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IsaacRe
Copy link

@IsaacRe IsaacRe commented Jan 30, 2023

Opening this up to get feedback on my code organization. See #731 for details.

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@olliestanley
Copy link
Collaborator

@IsaacRe Is this still WIP?

@IsaacRe IsaacRe changed the title [WIP] closes #731: add poetry-instructions dataset closes #731: add poetry-instructions dataset Feb 22, 2023
@IsaacRe
Copy link
Author

IsaacRe commented Feb 22, 2023

@olliestanley the PR is ready to go

@olliestanley
Copy link
Collaborator

@IsaacRe Sorry, could you please rebase this onto latest main? We have renamed openassistant directory to data. We have also added new code owners for the directory who will be able to review this once it is rebased :)

@CheckMC
Copy link
Contributor

CheckMC commented Apr 22, 2023

Hey @IsaacRe! I know this PR is a little old but I recently also made a poetry dataset (before we found this PR). It wouldn't hurt to have two, but maybe we could work to combine them. Lmk what you think and if you're still interested in this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants