Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a flaky test. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a flaky test. #1

wants to merge 1 commit into from

Conversation

LALAYANG
Copy link
Owner

@LALAYANG LALAYANG commented Jul 17, 2021

  1. The test failure:
  • Run the test com.braintreegateway.unittest.RequestBuilderTest#map with mvn edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=com.braintreegateway.unittest.RequestBuilderTest#map
  • Get some failures:
[ERROR] Failures:
[ERROR] RequestBuilderTest.map:53 expected: <<examples><color>green</color><insect>bee</insect></examples>> but was: <<examples><insect>bee</insect><color>green</color></examples>>
  1. Why it fails:
  • In src/test/java/com/braintreegateway/unittest/RequestBuilderTest.java : Map<String, Object> map = new HashMap<String, Object>(); HashMap makes no guarantee about the iteration order.
  1. Fix it:
  • By changing HashMap to LinkedHashMap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant