Skip to content

chore: Improve test coverage #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

chore: Improve test coverage #120

wants to merge 7 commits into from

Conversation

mhovd
Copy link
Collaborator

@mhovd mhovd commented Apr 14, 2025

QR Decomposition Improvements:

  • src/routines/evaluation/qr.rs: Replaced calculate_r with qrd, which includes row normalization and error handling for rows that sum to zero. Added detailed documentation and tests for the qrd function. [1] [2]

burke Function Enhancements:

  • src/routines/evaluation/ipm.rs: Added multiple tests for the burke function, covering various scenarios including identity matrices, uniform matrices, non-uniform matrices, negative values, and non-finite values. Simplified the row iteration logic. [1] [2] [3]

Documentation Updates:

  • src/lib.rs: Simplified the documentation, removing detailed configuration and data format descriptions, and linking to the pharmsol library for handling pharmacokinetic data.

Dependency Additions:

  • Cargo.toml: Added approx as a development dependency.

Code Cleanup:

  • src/algorithms/mod.rs: Removed unused import statements.
  • src/algorithms/npag.rs and src/algorithms/npod.rs: Replaced qr::calculate_r with qr::qrd to align with the new QR decomposition function. [1] [2]

@Copilot Copilot AI review requested due to automatic review settings April 14, 2025 14:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/routines/evaluation/ipm.rs:37

  • The function documentation and tests indicate that negative values should be handled by converting them to their absolute values, but the current implementation does not perform this conversion.
row.iter_mut().try_for_each(|x| {

Copy link
Contributor

github-actions bot commented Apr 14, 2025

🐰 Bencher Report

Branchtests
Testbedorion
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
bimodal_ke_fit📈 view plot
🚷 view threshold
18.54 s
(-1.17%)Baseline: 18.76 s
19.97 s
(92.83%)
🐰 View full continuous benchmarking report in Bencher

mhovd added 2 commits April 14, 2025 17:44
Because psi can contain very small values, we can check for exactly zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant