-
Notifications
You must be signed in to change notification settings - Fork 2
chore: Improve test coverage #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mhovd
wants to merge
7
commits into
main
Choose a base branch
from
tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames calculate_R to qrd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/routines/evaluation/ipm.rs:37
- The function documentation and tests indicate that negative values should be handled by converting them to their absolute values, but the current implementation does not perform this conversion.
row.iter_mut().try_for_each(|x| {
Co-authored-by: Copilot <[email protected]>
|
Branch | tests |
Testbed | orion |
Click to view all benchmark results
Benchmark | Latency | Benchmark Result seconds (s) (Result Δ%) | Upper Boundary seconds (s) (Limit %) |
---|---|---|---|
bimodal_ke_fit | 📈 view plot 🚷 view threshold | 18.54 s(-1.17%)Baseline: 18.76 s | 19.97 s (92.83%) |
Because psi can contain very small values, we can check for exactly zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QR Decomposition Improvements:
src/routines/evaluation/qr.rs
: Replacedcalculate_r
withqrd
, which includes row normalization and error handling for rows that sum to zero. Added detailed documentation and tests for theqrd
function. [1] [2]burke
Function Enhancements:src/routines/evaluation/ipm.rs
: Added multiple tests for theburke
function, covering various scenarios including identity matrices, uniform matrices, non-uniform matrices, negative values, and non-finite values. Simplified the row iteration logic. [1] [2] [3]Documentation Updates:
src/lib.rs
: Simplified the documentation, removing detailed configuration and data format descriptions, and linking to thepharmsol
library for handling pharmacokinetic data.Dependency Additions:
Cargo.toml
: Addedapprox
as a development dependency.Code Cleanup:
src/algorithms/mod.rs
: Removed unused import statements.src/algorithms/npag.rs
andsrc/algorithms/npod.rs
: Replacedqr::calculate_r
withqr::qrd
to align with the new QR decomposition function. [1] [2]