Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: seattle network helpers #3750

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

heyrutvik
Copy link
Collaborator

@heyrutvik heyrutvik commented May 19, 2023

  1. Python script to remove duplicate links
  2. Scala script to remove redundant nodes

Related doc: https://ec2-18-116-117-142.us-east-2.compute.amazonaws.com/doku.php?id=home:shapefile_to_osm_convertor


This change is Reviewable

@heyrutvik heyrutvik force-pushed the seattle-network-scripts branch from 3ffd3ed to 7bfb5b7 Compare May 22, 2023 16:28
@heyrutvik
Copy link
Collaborator Author

test!

@heyrutvik heyrutvik force-pushed the seattle-network-scripts branch from 7bfb5b7 to d66d6d3 Compare May 23, 2023 12:31
@heyrutvik
Copy link
Collaborator Author

test!

Copy link
Collaborator

@nikolayilyin nikolayilyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nitpick, otherwise looks good

src/main/python/scripts/remove_duplicate_links.py Outdated Show resolved Hide resolved
@heyrutvik heyrutvik requested a review from nikolayilyin June 1, 2023 14:17
Copy link
Collaborator

@nikolayilyin nikolayilyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants