Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realistic hunter2 #11

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Realistic hunter2 #11

wants to merge 29 commits into from

Conversation

ibrahimhroob
Copy link
Contributor

@ibrahimhroob ibrahimhroob commented Dec 16, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

In this PR, I updated the model to the actual Hunter V2 with a 1:1 scale and configured it for Ackermann steering control using ROS2 control.

The whole repo has been refactored, and improved. The new model is more realistic with accurate steering for the front wheels.

For more information please refer to the updated readme: https://github.com/LCAS/hunter_robot/tree/refactor?tab=readme-ov-file#hunter-robot-simulation

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes.

[optional] Are there any post deployment tasks we need to perform?

@ibrahimhroob ibrahimhroob marked this pull request as draft December 16, 2024 09:53
@ibrahimhroob ibrahimhroob changed the title WIP - Refactor Realistic hunter2 Dec 17, 2024
@ibrahimhroob ibrahimhroob marked this pull request as ready for review December 17, 2024 21:25
@marc-hanheide
Copy link
Member

I love it. Great step forward (make sure we report well!)

However, I feel little qualified to review. Maybe ask another AOC team member to test and check as well?

Copy link
Member

@marc-hanheide marc-hanheide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is too much for me in this to review without full testing. I approve, but hope somebody from the @LCAS/aoc_devs team can provide a review that includes trying to run this.

@marc-hanheide marc-hanheide requested a review from a team December 17, 2024 22:08
@ibrahimhroob ibrahimhroob self-assigned this Dec 18, 2024
@ibrahimhroob ibrahimhroob added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request refactor labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants