Hunter Gazebo Package Development #4
Conversation
There was a problem hiding this comment.
pinging also @ibrahimhroob
I would want a quick discussion here.
This is adding packages to this fork. It may be better to do as I suggested in LCAS/hunter_robot#3 (comment)
I.e., to leave this repository as a fork of https://github.com/agilexrobotics/hunter_ros2 with no added packages and only a few specific additions for L-CAS. This will make maintenance with regard to upstream much easier in my view. I would suggest that the changes (new packages) hunter_controller, hunter_description and hunter_gazebo go into https://github.com/LCAS/hunter_robot (as originally planned I think). Please see LCAS/hunter_robot#5 which was designed to remove the packages that should indeed only be in this repository.
I would then suggest to add a package hunter_bringup to https://github.com/LCAS/hunter_robot that
- depends on the other
hunter_*packages - contains all the config files (tmule, yaml,...) and launch files that in this PR were added in various places
Happy to discuss
|
Also pinging @LeonardoGuevara to chip in if needed. |
|
Hi @marc-hanheide , yes I agree with your suggestions, this started to get a little bit messy and needs cleaning up |
|
Hi @PabloEspejeLS, as Marc suggested we will leave the forked repo as it is and we will keep making the changes on https://github.com/LCAS/hunter_robot and make the forked repo a dependent package. Sorry will have to reject this PR. |
|
@PabloEspejeLS , Can you please update your changes to https://github.com/LCAS/hunter_robot, I will review them and refactor the code, and please delete the unnecessary branches. I did make https://github.com/LCAS/hunter_ros2 as a submodule, however, this is not the correct way to do it, I will fix that. |
|
@ibrahimhroob , is this done now? |
|
yes it is done |
What type of PR is this? (check all applicable)