Move semver check to PR workflow

LFDT-Lockness · Feb 29, 2024 · daf510d · daf510d
1 parent 977edba
commit daf510d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 20 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -23,10 +23,6 @@ jobs:
       && startsWith(github.ref_name, 'v')
     steps:
     - uses: actions/checkout@v3
-    - name: Check semver
-      uses: obi1kenobi/cargo-semver-checks-action@v2
-      with:
-        package: generic-ec
     - run: cargo publish -p generic-ec --token ${CRATES_TOKEN}
       env:
         CRATES_TOKEN: ${{ secrets.CRATES_TOKEN }}
@@ -39,10 +35,6 @@ jobs:
       && startsWith(github.ref_name, 'core-v')
     steps:
     - uses: actions/checkout@v3
-    - name: Check semver
-      uses: obi1kenobi/cargo-semver-checks-action@v2
-      with:
-        package: generic-ec-core
     - run: cargo publish -p generic-ec-core --token ${CRATES_TOKEN}
       env:
         CRATES_TOKEN: ${{ secrets.CRATES_TOKEN }}
@@ -54,14 +46,6 @@ jobs:
       github.ref_type == 'tag'
       && startsWith(github.ref_name, 'curves-v')
     steps:
-    # TODO: this fails because the currently published version doesn't compile
-    # by itself. A fix is present and will be published soon, uncomment this
-    # when it's published
-    # - uses: actions/checkout@v3
-    # - name: Check semver
-    #   uses: obi1kenobi/cargo-semver-checks-action@v2
-    #   with:
-    #     package: generic-ec-curves
     - run: cargo publish -p generic-ec-curves --token ${CRATES_TOKEN}
       env:
         CRATES_TOKEN: ${{ secrets.CRATES_TOKEN }}
@@ -74,10 +58,6 @@ jobs:
       && startsWith(github.ref_name, 'zkp-v')
     steps:
     - uses: actions/checkout@v3
-    - name: Check semver
-      uses: obi1kenobi/cargo-semver-checks-action@v2
-      with:
-        package: generic-ec-zkp
     - run: cargo publish -p generic-ec-zkp --token ${CRATES_TOKEN}
       env:
         CRATES_TOKEN: ${{ secrets.CRATES_TOKEN }}
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -134,3 +134,20 @@ jobs:
         cache-on-failure: "true"
     - name: Dry-run publish
       run: cargo publish --dry-run -p ${{ matrix.package }}
+  check-semver:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        package:
+        - generic-ec
+        - generic-ec-core
+        # TODO: this fails because the currently published version doesn't compile
+        # by itself. A fix is present and will be published soon, uncomment this
+        # when it's published
+        # - generic-ec-curves
+        - generic-ec-zkp
+    - uses: actions/checkout@v3
+    - name: Check semver
+      uses: obi1kenobi/cargo-semver-checks-action@v2
+      with:
+        package: ${{ package }}