Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(core): update AttributeUpdate methods returns #237

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Nov 25, 2024

Description

Associated issue: closes #232

Content description:

  • change:
    • AttributeUpdate::merge_incomplete return type to CMapResult<Self>
    • AttributeUpdate::merge_from_none return type to CMapResult<Self>
  • add:
    • AttributeUpdate::split_from_none fallback method
  • update all affected implementation

Additional information

  • Breaking change

@imrn99 imrn99 changed the title update AttributeUpdate sigs & default impl refactor!(core): update AttributeUpdate methods returns Nov 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.26%. Comparing base (a924645) to head (e6f3563).

Files with missing lines Patch % Lines
honeycomb-core/src/attributes/collections.rs 38.88% 11 Missing ⚠️
honeycomb-core/src/attributes/traits.rs 71.42% 2 Missing ⚠️
honeycomb-kernels/src/grisubal/model.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   79.21%   79.26%   +0.04%     
==========================================
  Files          52       52              
  Lines        6953     6950       -3     
==========================================
+ Hits         5508     5509       +1     
+ Misses       1445     1441       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@imrn99 imrn99 marked this pull request as ready for review November 25, 2024 08:28
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: update AttributeUpdate methods to fit new operation semantics
3 participants