Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTD and CI #144

Merged
merged 10 commits into from
Jan 8, 2025
Merged

Fix RTD and CI #144

merged 10 commits into from
Jan 8, 2025

Conversation

markcmiller86
Copy link
Member

  • Found and fixed some minor issues with generic macros including a UMR
  • Fix a leak of properties in the property-list interface

@markcmiller86 markcmiller86 changed the title Mix generic interface macros and property leak Fix generic interface macros and property leak Jun 8, 2024
@markcmiller86 markcmiller86 changed the title Fix generic interface macros and property leak Fix RTD and CI Jan 8, 2025
@markcmiller86
Copy link
Member Author

This PR was originally created (with branch mcm86-15may23-prop-leak) to fix a leak in the property interface. However, the fixes for that went into the main branch via another PR. So, when main was merged into the branch associated with this PR, the changes for the property leak we effectively removed because they were already on main.

Subsequently, I fixed some issues with both ReadTheDocs and CI. The windows CI was failing due to bad URL to HDF5 windows binary release. I was not able to find URL for the version originally used and so updated slightly which then also involved an update for Visual Studio.

All that said, the windows CI seems to randomly fail. I re-ran the failed job here a couple of times to get it to pass.

@markcmiller86 markcmiller86 merged commit f6d9171 into master Jan 8, 2025
3 checks passed
@markcmiller86 markcmiller86 deleted the mcm86-15may23-prop-leak branch January 8, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant