Windows CI testing and spelling fixes #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brtnfld
commented
Jan 8, 2025
brtnfld
commented
- Reworked the strndup function used for Windows testing.
- Reran the action multiple times, and it has never failed the Windows tests, thus far.
- Added a spell checker and fix some spelling errors
- Updated the Windows HDF5 CI version to 1.14.5
markcmiller86
approved these changes
Jan 8, 2025
| name: codespell | ||
| on: [push, pull_request] | ||
| jobs: | ||
| codespell: |
| @@ -107,10 +107,9 @@ jobs: | |||
| - name: download HDF5 for Windows | |||
| run: | | |||
| wget --quiet \ | |||
| https://support.hdfgroup.org/releases/hdf5/v1_14/v1_14_1/downloads/hdf5-1.14.1-2-Std-win10_64-vs17-clang.zip | |||
| unzip hdf5-1.14.1-2-Std-win10_64-vs17-clang.zip | |||
| https://support.hdfgroup.org/releases/hdf5/v1_14/v1_14_5/downloads/hdf5-1.14.5-win-vs2022_cl.msi | |||
There was a problem hiding this comment.
Thanks for updating to current. I had to go find a 1.14 release that was compatible enough with existing logic here that I didn't have to change much because I don't follow the Windows command line logic too well.
|
@brtnfld should we remove the retry logic from the workflow? |
Good point, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.