Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reshape method #1760

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
726da15
reshape methods
artv3 Nov 5, 2024
119cc95
Merge branch 'develop' into artv3/reshape
artv3 Dec 12, 2024
e105bae
Merge branch 'develop' into artv3/reshape
artv3 Dec 23, 2024
78d32b3
add alias for view type
artv3 Dec 23, 2024
9807f31
compile time reverse array
artv3 Dec 23, 2024
28e714d
review reshape example
artv3 Dec 23, 2024
fc1f6a8
clean up pass
artv3 Dec 23, 2024
4d05ea5
clean up reshape example
artv3 Dec 23, 2024
b0a836a
push up version that takes index_seq
artv3 Dec 23, 2024
a1a254d
fix bug with custom layout
artv3 Dec 26, 2024
a691f40
clean up based on pr comments
artv3 Dec 26, 2024
cf3ff8c
Update include/RAJA/util/View.hpp
artv3 Dec 26, 2024
7ddbdb1
fix inside function call
artv3 Dec 26, 2024
c33e1d1
merge develop + fix conflict
artv3 Jan 16, 2025
d09d6e0
make style
artv3 Jan 17, 2025
a9a9119
Merge branch 'develop' into artv3/reshape
rhornung67 Feb 20, 2025
fb46fec
Merge branch 'develop' into artv3/reshape
artv3 Mar 5, 2025
c2afb99
add docs
artv3 Mar 5, 2025
94cf153
clean up pass
artv3 Mar 5, 2025
a1534f3
fix spelling
artv3 Mar 5, 2025
41c4b0c
PR comments
artv3 Mar 5, 2025
0b98518
Update docs/sphinx/user_guide/feature/view.rst
artv3 Mar 5, 2025
a317bd5
Update docs/sphinx/user_guide/feature/view.rst
artv3 Mar 5, 2025
6dbbc9c
Update docs/sphinx/user_guide/feature/view.rst
artv3 Mar 5, 2025
5f39b64
Update docs/sphinx/user_guide/feature/view.rst
artv3 Mar 5, 2025
928bd1d
remove unused code
artv3 Mar 5, 2025
163f91c
clean up pass
artv3 Mar 5, 2025
1d3fd1d
clean up pass
artv3 Mar 5, 2025
d316505
another pass
artv3 Mar 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up reshape example
  • Loading branch information
artv3 committed Dec 23, 2024
commit 4d05ea506517e90ade55d13a656b091df3ca618d
6 changes: 3 additions & 3 deletions examples/reshape.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ constexpr int HIP_BLOCK_SIZE = 256;
//
//Function for checking results
//
void checkResult(int *ptr, int N, int M, int K);
void checkResult(int *ptr, int K, int N, int M);

int main(int RAJA_UNUSED_ARG(argc), char **RAJA_UNUSED_ARG(argv[]))
{
Expand Down Expand Up @@ -110,7 +110,7 @@ int main(int RAJA_UNUSED_ARG(argc), char **RAJA_UNUSED_ARG(argv[]))
//
// check result
//
void checkResult(int *ptr, int N, int M, int K)
void checkResult(int *ptr, int K, int N, int M)
{

bool status = true;
Expand All @@ -119,7 +119,7 @@ void checkResult(int *ptr, int N, int M, int K)
for(int n = 0; n < N; ++n) {
for(int m = 0; m < M; ++m) {
const int idx = m + M * (n + N * k);
if (std::abs(ptr[idx] - idx) > 1.0e-12) {
if (std::abs(ptr[idx] - idx) > 0) {
status = false;
}
}
Expand Down
Loading